Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755251Ab0KLHgH (ORCPT ); Fri, 12 Nov 2010 02:36:07 -0500 Received: from stinky.trash.net ([213.144.137.162]:55905 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753410Ab0KLHgE (ORCPT ); Fri, 12 Nov 2010 02:36:04 -0500 Message-ID: <4CDCEE65.3060105@trash.net> Date: Fri, 12 Nov 2010 08:36:05 +0100 From: Patrick McHardy User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100620 Icedove/3.0.5 MIME-Version: 1.0 To: Hua Zhong CC: "'Eric Paris'" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org, yoshfuji@linux-ipv6.org Subject: Re: [RFC PATCH] network: return errors if we know tcp_connect failed References: <20101111210341.31350.86916.stgit@paris.rdu.redhat.com> <00c201cb81eb$84e18160$8ea48420$@com> In-Reply-To: <00c201cb81eb$84e18160$8ea48420$@com> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 796 Lines: 14 On 11.11.2010 22:58, Hua Zhong wrote: >> Yes, I realize this is little different than if the >> SYN was dropped in the first network device, but it is different >> because we know what happened! We know that connect() call failed >> and that there isn't anything coming back. > > I would argue that -j DROP should behave exactly as the packet is dropped in the network, while -j REJECT should signal the failure to the application as soon as possible (which it doesn't seem to do). It sends an ICMP error or TCP reset. Interpretation is up to TCP. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/