Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757448Ab0KLMcs (ORCPT ); Fri, 12 Nov 2010 07:32:48 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:50013 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756625Ab0KLMcq convert rfc822-to-8bit (ORCPT ); Fri, 12 Nov 2010 07:32:46 -0500 From: "G, Manjunath Kondaiah" To: Emeltchenko Andrei , "linux-omap@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Fri, 12 Nov 2010 18:02:40 +0530 Subject: RE: [PATCHv3 2/4] OMAP1: Serial: remobe magic from MDR1 register Thread-Topic: [PATCHv3 2/4] OMAP1: Serial: remobe magic from MDR1 register Thread-Index: AcuCUVzB2XVvaZ6qRq2Chdw+Tq2RdgAExjyQ Message-ID: References: <1289553702-28041-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> <1289553702-28041-3-git-send-email-Andrei.Emeltchenko.news@gmail.com> In-Reply-To: <1289553702-28041-3-git-send-email-Andrei.Emeltchenko.news@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 925 Lines: 26 > -----Original Message----- > From: linux-omap-owner@vger.kernel.org > [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of > Emeltchenko Andrei > Sent: Friday, November 12, 2010 2:52 PM > To: linux-omap@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCHv3 2/4] OMAP1: Serial: remobe magic from MDR1 register 1. s/remobe/remove 2. s/remove magic/remove magic number After this also, patch title does not match with code. You are not modifying anything to MDR1 register. You are replacing hardcoded values in serial API's with macros defined in serial header. Pls fix patch title accordingly. -Manjunath [...]-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/