Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757522Ab0KLT2N (ORCPT ); Fri, 12 Nov 2010 14:28:13 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:54549 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756825Ab0KLT2L (ORCPT ); Fri, 12 Nov 2010 14:28:11 -0500 Date: Fri, 12 Nov 2010 11:28:36 -0800 (PST) Message-Id: <20101112.112836.183042210.davem@davemloft.net> To: kuznet@ms2.inr.ac.ru Cc: eparis@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, pekkas@netcore.fi, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net Subject: Re: [RFC PATCH] network: return errors if we know tcp_connect failed From: David Miller In-Reply-To: <20101112174620.GA16544@ms2.inr.ac.ru> References: <20101111210341.31350.86916.stgit@paris.rdu.redhat.com> <20101112174620.GA16544@ms2.inr.ac.ru> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 976 Lines: 20 From: Alexey Kuznetsov Date: Fri, 12 Nov 2010 20:46:20 +0300 > The only loophole is ICMP error in the same case as yours. In > _violation_ of specs linux immediately aborts unestablished connect > on an icmp error. IMHO that thing which you suggest is correct (of > course, provided you filter out transient errors and react only to > EPERM or something like this). It was not done because it was > expected firewall rule prescribing immediate abort is configured > with "--reject-with icmp-port-unreachable", otherwise the rule > orders real blackhole. The idea to signal on -EPERM might be OK, but if that's also what things like "-m statistical" and friends end up reporting then we still cannot do it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/