Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933145Ab0KLVu1 (ORCPT ); Fri, 12 Nov 2010 16:50:27 -0500 Received: from mail-qw0-f46.google.com ([209.85.216.46]:43880 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933096Ab0KLVuW convert rfc822-to-8bit (ORCPT ); Fri, 12 Nov 2010 16:50:22 -0500 MIME-Version: 1.0 X-Originating-IP: [81.245.35.135] In-Reply-To: <201011121217.11339.trenn@suse.de> References: <1289498595-25806-1-git-send-email-trenn@suse.de> <1289498595-25806-3-git-send-email-trenn@suse.de> <201011121217.11339.trenn@suse.de> Date: Fri, 12 Nov 2010 22:50:21 +0100 Message-ID: Subject: Re: [PATCH 2/3] PERF(kernel): Cleanup power events From: Jean Pihet To: Thomas Renninger Cc: mingo@elte.hu, rjw@sisk.pl, linux-kernel@vger.kernel.org, arjan@linux.intel.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2155 Lines: 69 On Fri, Nov 12, 2010 at 7:17 PM, Thomas Renninger wrote: > On Friday 12 November 2010 08:20:47 am Jean Pihet wrote: >> Thomas, > ... >> > + >> > + ? ? ? TP_printk("state=%lu cpu_id=%lu", (unsigned long)__entry->state, >> > + ? ? ? ? ? ? ? ? (unsigned long)__entry->cpu_id) >> Using %lu for the state field causes PWR_EVENT_EXIT to appear as >> 4294967295 instead of -1. Can the field be of a signed type? > This is intended, what exactly is the problem? There is no problem, I just wanted to warn about it. I am fine with it. > > ... >> > + ? ? ? TP_printk("state=%lu", (unsigned long)__entry->state) >> Same remark about the unsigned type for the state field. > Same. >> >> > +); >> > + >> > +#ifdef CONFIG_EVENT_POWER_TRACING_DEPRECATED >> > + >> > ?#ifndef _TRACE_POWER_ENUM_ >> > ?#define _TRACE_POWER_ENUM_ >> > ?enum { >> > @@ -153,8 +214,32 @@ DEFINE_EVENT(power_domain, power_domain_target, >> > >> > ? ? ? ?TP_ARGS(name, state, cpu_id) >> > ?); >> > - >> > +#endif /* CONFIG_EVENT_POWER_TRACING_DEPRECATED */ >> The clock and power_domain events have been recently introduced and so >> must be part of the new API. Can this #endif be moved right after the >> definition of power_end? > Oops, I pulled again meanwhile and the patches still patched without fuzz, > but probably with some offset. > I'll look at that and resend this one. Ok > >> > ?#endif /* _TRACE_POWER_H */ >> Should this be at the very end of the file? > Not sure whether this also came from merge issues, but yes, several > #ifdef conditions need to get corrected. Ok > > ... > >> A string is needed here. Without it it is impossible to have the option >> unset. >> This does the trick: +bool "Deprecated power event trace API, to be removed" > Ok, thanks. > > I am currently rebuilding on several archs/flavors and hope to be able > to re-send this one today or on Tue. > > Thanks, > > ? ?Thomas > Thanks! Jean -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/