DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject
         :references:in-reply-to:content-type:content-transfer-encoding;
        b=B8s34egeNmfliOP/xWRRzYdI3Bq/tR8JjqtjQuthxZy0Vf8S/H7uCt5dHRVWFuRraH
         HGokUHqsEAODT1YArcm3DLFZfUMEkKe0+GFcL/m0V2nr7ZUkABVqP6Ov5ZKj3lPEkUJb
         qTb2u/eesi8CU4K1qe831vXKJMGkLKlRiZd3I=
Message-ID: <4CDE2199.7080309@garzik.org>
Date: Sat, 13 Nov 2010 00:26:49 -0500
From: Jeff Garzik <jeff@garzik.org>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101027 Fedora/3.1.6-1.fc13 Thunderbird/3.1.6
MIME-Version: 1.0
To: Linus Torvalds <torvalds@linux-foundation.org>
CC: Matthew Wilcox <matthew@wil.cx>, James Bottomley <James.Bottomley@suse.de>,
        "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-scsi <linux-scsi@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] SCSI queuecommand API change for 2.6.37-rc1
References: <1289606118.3015.539.camel@mulgrave.site> <AANLkTinj2BM2eGo2yyfzs=t+nu79WLW_bGYota9sDZwH@mail.gmail.com> <20101113042821.GE18258@parisc-linux.org> <AANLkTik_eXv1_ZaqD01CoT6igzjBZtmECD0e+QUkMhxP@mail.gmail.com>
In-Reply-To: <AANLkTik_eXv1_ZaqD01CoT6igzjBZtmECD0e+QUkMhxP@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1054
Lines: 29

On 11/12/2010 11:42 PM, Linus Torvalds wrote:
> Having to inevitably do that silly double dereference
> ("cmd->device->host") seems bogus. Passing in the host you want to
> queue something on seems to be natural, and avoids that nasty chain of
> dereferences, so it really should improve the code.

As noted in the patch v4, just sent, I agree.


> So the shost pointer is certainly a lot more useful than the 'done'
> function pointer.  So yeah, I'd switch them around - pass the 'done'
> thing indirectly, and the shost directly.

You bozos would come up with this the _minute_ I sent my patch, eh?  :)

IMO, the 'done' removal should be in a separate patch from the host lock 
push-down.

It should be straightforward, if applied immediately following the 
push-down patch.  bisect remains clean.

	Jeff


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/