Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932105Ab0KMTj7 (ORCPT ); Sat, 13 Nov 2010 14:39:59 -0500 Received: from casper.infradead.org ([85.118.1.10]:42572 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755352Ab0KMTj4 convert rfc822-to-8bit (ORCPT ); Sat, 13 Nov 2010 14:39:56 -0500 Subject: Re: [RFC][PATCH v2 1/7] taskstats: Add new taskstats command TASKSTATS_CMD_ATTR_PIDS From: Peter Zijlstra To: Michael Holzheu Cc: Shailabh Nagar , Andrew Morton , Venkatesh Pallipadi , Suresh Siddha , Ingo Molnar , Oleg Nesterov , John stultz , Thomas Gleixner , Balbir Singh , Martin Schwidefsky , Heiko Carstens , Roland McGrath , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org In-Reply-To: <20101111170813.527389224@linux.vnet.ibm.com> References: <20101111170352.732381138@linux.vnet.ibm.com> <20101111170813.527389224@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Sat, 13 Nov 2010 20:39:44 +0100 Message-ID: <1289677184.2109.171.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 597 Lines: 12 On Thu, 2010-11-11 at 18:03 +0100, Michael Holzheu wrote: > + if (cmd_pids->cnt > 1000) // XXX socket buffer size check What's the implication of this limit? Does that mean that if there's more than 1000 tasks on the system the whole interface falls flat on its face or does that mean we get at most 1000 tasks worth of information per syscall? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/