From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Bruno Randolf <br1@einfach.org>
Subject: Re: [PATCH v6] Add generic exponentially weighted moving average (EWMA) function
Cc: kosaki.motohiro@jp.fujitsu.com, Stefan Richter <stefanr@s5r6.in-berlin.de>,
        Andrew Morton <akpm@linux-foundation.org>, randy.dunlap@oracle.com,
        peterz@infradead.org, blp@cs.stanford.edu,
        linux-kernel@vger.kernel.org, Lars_Ericsson@telia.com,
        kevin.granade@gmail.com, "John W. Linville" <linville@tuxdriver.com>
In-Reply-To: <201011121044.40274.br1@einfach.org>
References: <4CDC333E.4070104@s5r6.in-berlin.de> <201011121044.40274.br1@einfach.org>
Message-Id: <20101114133029.E008.A69D9226@jp.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Date: Sun, 14 Nov 2010 14:07:10 +0900 (JST)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 799
Lines: 21

> > Why do ewma_init() and ewma_add() return their first argument?  They look
> > to me like they can be straight-forward void functions.
> 
> You are right, for ewma_init() it does not make sense.
> 
> For ewma_add() I think it does. This has been discussed before (e.g. 
> http://linux.derkeiler.com/Mailing-Lists/Kernel/2010-10/msg09124.html).
> Some people might want to get the value when they add a sample by using 
> ewma_get(ewma_add(&ewma, val));

	ewma_add(&ewma, val);
	ewma_get(&ewma);

is enough simpler and cleaner. I don't oppse this :)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/