Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752442Ab0KNMgM (ORCPT ); Sun, 14 Nov 2010 07:36:12 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:55949 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751340Ab0KNMgL (ORCPT ); Sun, 14 Nov 2010 07:36:11 -0500 Date: Sun, 14 Nov 2010 13:35:17 +0100 From: Ingo Molnar To: Linus Torvalds Cc: Dan Rosenberg , James Morris , Joe Perches , LKML , Eugene Teo , Kees Cook , Andrew Morton Subject: Re: [PATCH] Fix dmesg_restrict build failure with CONFIG_EMBEDDED=y and CONFIG_PRINTK=n Message-ID: <20101114123517.GA11808@elte.hu> References: <1289669176.16461.12.camel@Joe-Laptop> <1289672721.3090.349.camel@Dan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1143 Lines: 32 * Linus Torvalds wrote: > (The diffstat says that this adds more lines than it removes, but that > is misleading: it is due to actually commenting the rule that checks > are done open-time for /proc/kmsg) > > Linus > > include/linux/security.h | 11 +++++------ > kernel/printk.c | 15 ++++++++++++--- > kernel/sysctl.c | 2 +- > security/commoncap.c | 7 +------ > security/security.c | 4 ++-- > security/selinux/hooks.c | 4 ++-- > security/smack/smack_lsm.c | 4 ++-- > 7 files changed, 25 insertions(+), 22 deletions(-) I gave it some testing in -tip and your patch also solves the !EMBEDDED build bug (and it also still restricts unprivileged dmesg output when desired), so: Acked-by: Ingo Molnar Tested-by: Ingo Molnar Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/