Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757007Ab0KOA1g (ORCPT ); Sun, 14 Nov 2010 19:27:36 -0500 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:56452 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755562Ab0KOA1f (ORCPT ); Sun, 14 Nov 2010 19:27:35 -0500 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: Jesper Juhl Subject: Re: [PATCH] cleanup kswapd() Cc: kosaki.motohiro@jp.fujitsu.com, Mel Gorman , LKML , linux-mm , Andrew Morton In-Reply-To: References: <20101114180505.BEE2.A69D9226@jp.fujitsu.com> Message-Id: <20101115092712.BEF4.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50.07 [ja] Date: Mon, 15 Nov 2010 09:27:32 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1046 Lines: 39 > On Sun, 14 Nov 2010, KOSAKI Motohiro wrote: > > > > > Currently, kswapd() function has deeper nest and it slightly harder to > > read. cleanup it. > > > > Cc: Mel Gorman > > Signed-off-by: KOSAKI Motohiro > > --- > > mm/vmscan.c | 71 +++++++++++++++++++++++++++++++--------------------------- > > 1 files changed, 38 insertions(+), 33 deletions(-) > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index 8cc90d5..82ffe5f 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -2364,6 +2364,42 @@ out: > > return sc.nr_reclaimed; > > } > > > > +void kswapd_try_to_sleep(pg_data_t *pgdat, int order) > > Shouldn't this be > > static void kswapd_try_to_sleep(pg_data_t *pgdat, int order) > > ?? Right. thank you. I'll respin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/