Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933236Ab0KORrV (ORCPT ); Mon, 15 Nov 2010 12:47:21 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:44602 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933194Ab0KORrS (ORCPT ); Mon, 15 Nov 2010 12:47:18 -0500 MIME-Version: 1.0 In-Reply-To: References: <1289669176.16461.12.camel@Joe-Laptop> <1289677904.16461.82.camel@Joe-Laptop> From: Linus Torvalds Date: Mon, 15 Nov 2010 09:41:25 -0800 Message-ID: Subject: Re: [PATCH] Fix dmesg_restrict build failure with CONFIG_EMBEDDED=y and CONFIG_PRINTK=n To: Eric Paris Cc: Joe Perches , Dan Rosenberg , LKML , Ingo Molnar , Eugene Teo , Kees Cook , Andrew Morton , James Morris , LSM List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1004 Lines: 23 On Mon, Nov 15, 2010 at 9:34 AM, Eric Paris wrote: > > I'm sure somebody somewhere hates it, but I was thinking something > like the attached. I certainly like it. If the old rule should have been that you _have_ to call cap_syslog(), then just eviscerating that entirely and putting it in the generic code is definitely the right thing. Anyway, I wanted to do -rc2 yesterday, but I don't really want this kernel build problem to remain (even if it's not a very relevant config for most people). So if people can quickly agree on this, I'll take it and do -rc2 later today, otherwise I'll do Joe's trivial patch as a stop-gap measure pending approval for cleanup/fixing the security interfaces. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/