Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758145Ab0KOShb (ORCPT ); Mon, 15 Nov 2010 13:37:31 -0500 Received: from smtp-vbr13.xs4all.nl ([194.109.24.33]:2515 "EHLO smtp-vbr13.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757108Ab0KOSha (ORCPT ); Mon, 15 Nov 2010 13:37:30 -0500 Message-ID: <4CE17DDE.8050207@xs4all.nl> Date: Mon, 15 Nov 2010 19:37:18 +0100 From: Jim Bos User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101106 Thunderbird/3.1.6 MIME-Version: 1.0 To: Linus Torvalds CC: Jakub Jelinek , Andi Kleen , James Cloos , Linux Kernel Mailing List , Andreas Schwab , Michael Matz , Dave Korn , Richard Guenther , gcc@gcc.gnu.org Subject: Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/i8k.c ? References: <4CD843DC.10106@gmail.com> <20101109134816.GB29433@basil.fritz.box> <4CD97A3D.1040602@xs4all.nl> <20101115085605.GE2583@sunsite.ms.mff.cuni.cz> <20101115100331.GG2583@sunsite.ms.mff.cuni.cz> <20101115105446.GD7269@basil.fritz.box> <20101115111642.GU29412@tyan-ft48-01.lab.bos.redhat.com> <4CE17098.8090000@xs4all.nl> <4CE17C4B.1070305@xs4all.nl> In-Reply-To: <4CE17C4B.1070305@xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1503 Lines: 45 On 11/15/2010 07:30 PM, Jim Bos wrote: > On 11/15/2010 07:08 PM, Linus Torvalds wrote: >> On Mon, Nov 15, 2010 at 9:40 AM, Jim Bos wrote: >>> >>> Hmm, that doesn't work. >>> >>> [ Not sure if you read to whole thread but initial workaround was to >>> change the asm(..) to asm volatile(..) which did work. ] >> >> Since I have a different gcc than yours (and I'm not going to compile >> my own), have you posted your broken .s file anywhere? In fact, with >> the noinline (and the removal of the "+m" thing - iow just the patch >> you tried), what does just the "i8k_smm" function assembly look like >> for you after you've done a "make drivers/char/i8k.s"? >> >> If the asm just doesn't exist AT ALL, that's just odd. Because every >> single call-site of i8k_smm() clearly looks at the return value. So >> the volatile really shouldn't make any difference from that >> standpoint. Odd. >> >> Linus >> > > Attached version with plain 2.6.36 source and version with the committed > patch, i.e with the '"+m" (*regs)' > > > _ > Jim > > And I just tried with your noninline patch which results in exactly the same .s file as with plain 2.6.36 source, i.e. the noninline patch is not doing anything here. _ Jim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/