Date: Mon, 15 Nov 2010 20:19:55 +0100
From: Oleg Nesterov <oleg@redhat.com>
To: David Daney <ddaney@caviumnetworks.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, arnd@arndb.de,
        benh@kernel.crashing.org, cmetcalf@tilera.com, davem@davemloft.net,
        deller@gmx.de, heiko.carstens@de.ibm.com, hpa@zytor.com,
        jejb@parisc-linux.org, kyle@mcmartin.ca, mingo@elte.hu,
        roland@redhat.com, schwidefsky@de.ibm.com, tglx@linutronix.de,
        tony.luck@intel.com
Subject: Re: +
	exec_domain-establish-a-linux32-domain-on-config_compat-systems.patc
	h added to -mm tree
Message-ID: <20101115191955.GA17342@redhat.com>
References: <201011122022.oACKM6HH029696@imap1.linux-foundation.org> <20101113171722.GA2956@redhat.com> <4CE182A2.1020606@caviumnetworks.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4CE182A2.1020606@caviumnetworks.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1313
Lines: 37

On 11/15, David Daney wrote:
>
> On 11/13/2010 09:17 AM, Oleg Nesterov wrote:
>>
>>> We can avoid the failed module loading overhead by building-in the
>>> linux32_exec_domain for systems that have CONFIG_COMPAT.
>>
>> Indeed. But at the same time this means it is not possible to use
>> personality-8.ko if the system has it.
>
> Well in the same way it is not possible to use personality-0.ko
> (PER_LINUX) because it is just as built-in.

Sure, but this was never possible. But your patch adds the obvious
user-visible change.

>> Don't get me wrong, I have no idea why anyone could want this module,
>> just I am a bit worried.
>
> If the personality is built-in, then I don't see how it makes any sense
> to attempt to override it with an externally supplied version.  If you
> want set a domain for PER_LINUX32, don't configure you system to supply
> a default version.

Well, no need to convince me ;) To me, this request_module() doesn't
make any sense at all.

I won't argue against this change. Just I wanted to be sure this
issue is not overlooked.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/