Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758215Ab0KOTxa (ORCPT ); Mon, 15 Nov 2010 14:53:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:23422 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756336Ab0KOTx3 (ORCPT ); Mon, 15 Nov 2010 14:53:29 -0500 Message-ID: <4CE18FA1.4000400@redhat.com> Date: Mon, 15 Nov 2010 11:53:05 -0800 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Thunderbird/3.1.6 MIME-Version: 1.0 To: Jakub Jelinek CC: Linus Torvalds , Jim Bos , Andi Kleen , James Cloos , Linux Kernel Mailing List , Andreas Schwab , Michael Matz , Dave Korn , Richard Guenther , gcc@gcc.gnu.org Subject: Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/i8k.c ? References: <20101115085605.GE2583@sunsite.ms.mff.cuni.cz> <20101115100331.GG2583@sunsite.ms.mff.cuni.cz> <20101115105446.GD7269@basil.fritz.box> <20101115111642.GU29412@tyan-ft48-01.lab.bos.redhat.com> <4CE17098.8090000@xs4all.nl> <4CE17C4B.1070305@xs4all.nl> <20101115185848.GI2583@sunsite.ms.mff.cuni.cz> <20101115191248.GY29412@tyan-ft48-01.lab.bos.redhat.com> In-Reply-To: <20101115191248.GY29412@tyan-ft48-01.lab.bos.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 571 Lines: 14 On 11/15/2010 11:12 AM, Jakub Jelinek wrote: > - if (simple_cst_equal(TREE_VALUE (op), memory_identifier_string) == 1) > + if (strcmp (TREE_STRING_POINTER (TREE_VALUE (link)), "memory") == 0) I prefer this solution. I think memory_identifier_string is over-engineering. Patch to remove it entirely is pre-approved. r~ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/