Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758554Ab0KOVsn (ORCPT ); Mon, 15 Nov 2010 16:48:43 -0500 Received: from e6.ny.us.ibm.com ([32.97.182.146]:37955 "EHLO e6.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754847Ab0KOVsm (ORCPT ); Mon, 15 Nov 2010 16:48:42 -0500 Date: Mon, 15 Nov 2010 13:48:31 -0800 From: "Darrick J. Wong" To: "Theodore Ts'o" , "Patrick J. LoPresti" Cc: linux-kernel , linux-ext4 , Mingming Cao Subject: [PATCH] ext4: ext4_fill_super shouldn't return 0 on corruption Message-ID: <20101115214831.GA18195@tux1.beaverton.ibm.com> Reply-To: djwong@us.ibm.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1624 Lines: 37 At the start of ext4_fill_super, ret is set to -EINVAL, and any failure path out of that function returns this ret. However, the generic_check_addressable clause sets ret = 0 if it passes, which means that a subsequent failure (e.g. a group checksum error) returns 0 even though the mount should fail. This causes vfs_kern_mount in turn to think that the mount succeeded (because PTR_ERR(0) is false), leading to an oops. A simple fix is to avoid using ret for the generic_check_addressable check, which was last changed in commit 30ca22c70e3ef0a96ff84de69cd7e8561b416cb2. Signed-off-by: Darrick J. Wong --- fs/ext4/super.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 40131b7..a44bc59 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -3257,9 +3257,8 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) * Test whether we have more sectors than will fit in sector_t, * and whether the max offset is addressable by the page cache. */ - ret = generic_check_addressable(sb->s_blocksize_bits, - ext4_blocks_count(es)); - if (ret) { + if (generic_check_addressable(sb->s_blocksize_bits, + ext4_blocks_count(es))) { ext4_msg(sb, KERN_ERR, "filesystem" " too large to mount safely on this system"); if (sizeof(sector_t) < 8) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/