Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933896Ab0KOW7w (ORCPT ); Mon, 15 Nov 2010 17:59:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:31566 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933831Ab0KOW7v (ORCPT ); Mon, 15 Nov 2010 17:59:51 -0500 Message-ID: <4CE1BB10.5090501@redhat.com> Date: Mon, 15 Nov 2010 15:58:24 -0700 From: Jeff Law User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.6 MIME-Version: 1.0 To: Richard Guenther CC: Andi Kleen , Andreas Schwab , Jim , Linux Kernel Mailing List , gcc@gcc.gnu.org Subject: Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/i8k.c ? References: <4CD538CA.8010901@xs4all.nl> <87wroostw3.fsf@basil.nowhere.org> <87k4kospnd.fsf@basil.nowhere.org> <4CE17FB6.7000800@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1155 Lines: 22 On 11/15/10 15:07, Richard Guenther wrote: > On Mon, Nov 15, 2010 at 7:45 PM, Jeff Law wrote: >> On 11/08/10 03:49, Richard Guenther wrote: >>> On Mon, Nov 8, 2010 at 12:03 AM, Andi Kleen wrote: >>>> Andreas Schwab writes: >>>>> The asm fails to mention that it modifies *regs. >>>> It has a memory clobber, that should be enough, no? >>> No. A memory clobber does not cover automatic storage. >> A memory clobber should clobber anything in memory, including autos in >> memory; if it doesn't, then that seems like a major problem. I'd like to >> see the rationale behind not clobbering autos in memory. > Non-address taken automatic storage. (note that we don't excercise this > in optimization yet) If the address of the auto isn't taken, then why is the object in memory to begin with (with the obvious exception for aggregates). Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/