Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759355Ab0KPEuF (ORCPT ); Mon, 15 Nov 2010 23:50:05 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:55259 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756842Ab0KPEuE convert rfc822-to-8bit (ORCPT ); Mon, 15 Nov 2010 23:50:04 -0500 From: "Nori, Sekhar" To: Nicolas Kaiser , Kevin Hilman CC: "davinci-linux-open-source@linux.davincidsp.com" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Tue, 16 Nov 2010 10:19:49 +0530 Subject: RE: [PATCH] mach-davinci: signedness bug Thread-Topic: [PATCH] mach-davinci: signedness bug Thread-Index: AcuE9Pmvb28aoVqoR5mrq2bCBSBO3gAU/OyQ Message-ID: References: <20101115194028.30f8b7f0@absol.kitzblitz> In-Reply-To: <20101115194028.30f8b7f0@absol.kitzblitz> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1580 Lines: 49 Hi Nicolas, On Tue, Nov 16, 2010 at 00:10:28, Nicolas Kaiser wrote: > aemif_calc_rate() can return a negative error value, so all the > variables that get tested for this value need to be signed. > > The maximum bit width of WSETUP(WSETUP_MAX) appears to be 30 bits > (0xf << 26). Using a signed instead of an unsigned integer > shouldn't make a difference here. > > Signed-off-by: Nicolas Kaiser Thanks for the fix. You could use the subject: "davinci: signedness bug in davinci_aemif_setup_timing()" Other than that: Acked-by: Sekhar Nori Thanks, Sekhar > --- > arch/arm/mach-davinci/aemif.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-davinci/aemif.c b/arch/arm/mach-davinci/aemif.c > index 9c3f500..1ce70a9 100644 > --- a/arch/arm/mach-davinci/aemif.c > +++ b/arch/arm/mach-davinci/aemif.c > @@ -90,7 +90,7 @@ int davinci_aemif_setup_timing(struct davinci_aemif_timing *t, > void __iomem *base, unsigned cs) > { > unsigned set, val; > - unsigned ta, rhold, rstrobe, rsetup, whold, wstrobe, wsetup; > + int ta, rhold, rstrobe, rsetup, whold, wstrobe, wsetup; > unsigned offset = A1CR_OFFSET + cs * 4; > struct clk *aemif_clk; > unsigned long clkrate; > -- > 1.7.2.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/