Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753166Ab0KPFaI (ORCPT ); Tue, 16 Nov 2010 00:30:08 -0500 Received: from sm-d311v.smileserver.ne.jp ([203.211.202.206]:39819 "EHLO sm-d311v.smileserver.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751783Ab0KPFaF (ORCPT ); Tue, 16 Nov 2010 00:30:05 -0500 Message-ID: <001801cb854f$527a2bc0$66f8800a@maildom.okisemi.com> From: "Tomoya MORINAGA" To: "Marc Kleine-Budde" Cc: "Wolfgang Grandegger" , "David S. Miller" , "Wolfram Sang" , "Christian Pellegrin" , "Barry Song" <21cnbao@gmail.com>, "Samuel Ortiz" , , , "LKML" , , , , , "Masayuki Ohtake" , , References: <4CE0EFA7.9020007@dsn.okisemi.com> <4CE0FF5A.3000100@pengutronix.de> Subject: Re: [PATCH net-next-2.6 v2] can: Topcliff: PCH_CAN driver: Add Flow control, Date: Tue, 16 Nov 2010 14:30:03 +0900 MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1983 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1983 X-Hosting-Pf: 0 X-NAI-Spam-Score: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 601 Lines: 21 Hi Marc, On Monday, November 15, 2010 6:37 PM, Marc Kleine-Budde wrote : > Either use ioread8 or ioread16 in both the rx and tx path. I will modify to ioread16 >> + if (ioread32(&priv->regs->treq2) & 0xfc00) { > what does this if check? This is for whether all tx requests are complete or not. --- Thanks, Tomoya MORINAGA OKI SEMICONDUCTOR CO., LTD. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/