Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933486Ab0KPL2X (ORCPT ); Tue, 16 Nov 2010 06:28:23 -0500 Received: from casper.infradead.org ([85.118.1.10]:46345 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932917Ab0KPL2V (ORCPT ); Tue, 16 Nov 2010 06:28:21 -0500 Subject: Re: [PATCH 05/11] drivers/net/irda: Remove unnecessary casts of pci_get_drvdata From: Samuel Ortiz Reply-To: Samuel Ortiz To: Joe Perches Cc: Jiri Kosina , netdev@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <11b30b9512bf0438efaf70d6c0a819756dbf0e2f.1289851770.git.joe@perches.com> References: <11b30b9512bf0438efaf70d6c0a819756dbf0e2f.1289851770.git.joe@perches.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 16 Nov 2010 12:27:55 +0100 Message-ID: <1289906875.7016.1.camel@sortiz-mobl> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2280 Lines: 66 Hi Joe, On Mon, 2010-11-15 at 12:13 -0800, Joe Perches wrote: > Signed-off-by: Joe Perches Thanks, I'll apply it to my irda tree. Cheers, Samuel. > --- > drivers/net/irda/donauboe.c | 6 +++--- > drivers/net/irda/vlsi_ir.c | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/irda/donauboe.c b/drivers/net/irda/donauboe.c > index b626ccc..bee5ccc 100644 > --- a/drivers/net/irda/donauboe.c > +++ b/drivers/net/irda/donauboe.c > @@ -1488,7 +1488,7 @@ static void > toshoboe_close (struct pci_dev *pci_dev) > { > int i; > - struct toshoboe_cb *self = (struct toshoboe_cb*)pci_get_drvdata(pci_dev); > + struct toshoboe_cb *self = pci_get_drvdata(pci_dev); > > IRDA_DEBUG (4, "%s()\n", __func__); > > @@ -1698,7 +1698,7 @@ freeself: > static int > toshoboe_gotosleep (struct pci_dev *pci_dev, pm_message_t crap) > { > - struct toshoboe_cb *self = (struct toshoboe_cb*)pci_get_drvdata(pci_dev); > + struct toshoboe_cb *self = pci_get_drvdata(pci_dev); > unsigned long flags; > int i = 10; > > @@ -1727,7 +1727,7 @@ toshoboe_gotosleep (struct pci_dev *pci_dev, pm_message_t crap) > static int > toshoboe_wakeup (struct pci_dev *pci_dev) > { > - struct toshoboe_cb *self = (struct toshoboe_cb*)pci_get_drvdata(pci_dev); > + struct toshoboe_cb *self = pci_get_drvdata(pci_dev); > unsigned long flags; > > IRDA_DEBUG (4, "%s()\n", __func__); > diff --git a/drivers/net/irda/vlsi_ir.c b/drivers/net/irda/vlsi_ir.c > index c3d0738..62f2d12 100644 > --- a/drivers/net/irda/vlsi_ir.c > +++ b/drivers/net/irda/vlsi_ir.c > @@ -542,7 +542,7 @@ static int vlsi_process_rx(struct vlsi_ring *r, struct ring_descr *rd) > int crclen, len = 0; > struct sk_buff *skb; > int ret = 0; > - struct net_device *ndev = (struct net_device *)pci_get_drvdata(r->pdev); > + struct net_device *ndev = pci_get_drvdata(r->pdev); > vlsi_irda_dev_t *idev = netdev_priv(ndev); > > pci_dma_sync_single_for_cpu(r->pdev, rd_get_addr(rd), r->len, r->dir); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/