Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758265Ab0KPOir (ORCPT ); Tue, 16 Nov 2010 09:38:47 -0500 Received: from e5.ny.us.ibm.com ([32.97.182.145]:39292 "EHLO e5.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756232Ab0KPOiq (ORCPT ); Tue, 16 Nov 2010 09:38:46 -0500 Subject: Re: [PATCH v1.3 4/4] keys: add new key-type encrypted From: Mimi Zohar To: David Howells Cc: linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@linux-nfs.org, linux-crypto@vger.kernel.org, Jason Gunthorpe , James Morris , David Safford , Rajiv Andrade , Mimi Zohar In-Reply-To: <23151.1289916524@redhat.com> References: <1289849751.3027.17.camel@localhost.localdomain> <1289694826.3257.82.camel@localhost.localdomain> <1289595738.2731.80.camel@localhost.localdomain> <1289404309-15955-5-git-send-email-zohar@linux.vnet.ibm.com> <1289404309-15955-1-git-send-email-zohar@linux.vnet.ibm.com> <26689.1289591135@redhat.com> <27900.1289597013@redhat.com> <8268.1289837934@redhat.com> <23151.1289916524@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 16 Nov 2010 09:38:40 -0500 Message-ID: <1289918320.3188.16.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 (2.30.3-1.fc13) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1278 Lines: 32 On Tue, 2010-11-16 at 14:08 +0000, David Howells wrote: > Mimi Zohar wrote: > > > Am assuming you mean something like this: > > > > keyctl add encrypted name "new trusted:master-key-name keylen" ring > > keyctl add encrypted name "new user:master-key-name keylen" ring > > > > and, as you said, works without changing the API. > > No, that's not what I mean. I maeant that when your internal functions look > for the user key, they should preface the description with a prefix. > > It should be handled in request_user_key() or request_master_key(). The > description given to request_trusted_key() should have the prefix applied > there. There's no need to mention it at all in the encrypted key add_key > command line. > > David I actually like keyctl requiring 'trusted:' or 'user:'. Forcing the user to indicate which type of key they want, is actually good - no misunderstandings. Another benefit, would be allowing 'keyctl update' to update the key description, not the key type. Mimi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/