Date: Tue, 16 Nov 2010 13:46:52 -0800
From: Greg KH <greg@kroah.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: Dirk Brandewie <dirk.brandewie@gmail.com>,
        Alan Stern <stern@rowland.harvard.edu>, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org,
        David Brownell <dbrownell@users.sourceforge.net>
Subject: Re: [PATCH 6/6] ce4100: Add support for CE4100 EHCI IP block to
 EHCI driver
Message-ID: <20101116214652.GB18387@kroah.com>
References: <Pine.LNX.4.44L0.1011092134180.14099-100000@netrider.rowland.org>
 <4CDA7925.10707@ru.mvista.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4CDA7925.10707@ru.mvista.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1902
Lines: 53

On Wed, Nov 10, 2010 at 01:51:17PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 10-11-2010 5:36, Alan Stern wrote:
> 
> >>In a previous patch in this series GregKH asked that the PCI ID not be added
> >>to pci_ids.h for ID's that are only used by a single file.
> >>Here is an updated version of the EHCI controller patch.
> 
> >>Subject: [PATCH] ce4100: Add support for CE4100 EHCI IP block to EHCI driver
> 
> >>This patch adds support for the EHCI IP block present on the Intel
> >>CE4100.
> 
> >>Signed-off-by: Dirk Brandewie<dirk.brandewie@gmail.com>
> >>CC: linux-usb@vger.kernel.org
> >>CC: David Brownell<dbrownell@users.sourceforge.net>
> >>---
> >>  drivers/usb/host/ehci-pci.c |    4 ++++
> >>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> >>diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
> >>index a1e8d27..da2b196 100644
> >>--- a/drivers/usb/host/ehci-pci.c
> >>+++ b/drivers/usb/host/ehci-pci.c
> >>@@ -124,6 +124,10 @@ static int ehci_pci_setup(struct usb_hcd *hcd)
> >>  			ehci_info(ehci, "disable lpm for langwell/penwell\n");
> >>  			ehci->has_lpm = 0;
> >>  		}
> >>+		if (pdev->device == 0x2e70) {
> >>+			hcd->has_tt = 1;
> >>+			tdi_reset(ehci);
> >>+		}
> 
> >I think Greg meant that it's okay to use a symbolic constant for the
> >PCI ID (it helps tell people what hardware is being handled).  Just
> >don't add that constant to the pci_ids.h file.
> 
>    Or at least you need a comment naming the hardware that this ID belongs to.

I agree, something a bit better than just the device id might be nice
here.

Dirk, care to redo this one and your serial one, with that idea?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/