Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759564Ab0KQC7S (ORCPT ); Tue, 16 Nov 2010 21:59:18 -0500 Received: from mail-iw0-f174.google.com ([209.85.214.174]:35029 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756851Ab0KQC7P (ORCPT ); Tue, 16 Nov 2010 21:59:15 -0500 MIME-Version: 1.0 In-Reply-To: <4CE33C14.9030503@gmail.com> References: <9129f0a21ea48fb2dcb89cea290e88f3e8c0d8a2.1289943240.git.dirk.brandewie@gmail.com> <4CE32453.2090403@caviumnetworks.com> <4CE33C14.9030503@gmail.com> From: Grant Likely Date: Tue, 16 Nov 2010 19:58:54 -0700 X-Google-Sender-Auth: gcuskphhyxv-NVC5qtTTuEi5KCk Message-ID: Subject: Re: [PATCH 1/5] of: Add support for linking device tree blobs into vmlinux To: Dirk Brandewie Cc: David Daney , devicetree-discuss@lists.ozlabs.org, sodaville@linutronix.de, arjan@linux.intel.com, linuxppc-dev@lists.ozlabs.org, microblaze-uclinux@itee.uq.edu.au, linux-arch@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1471 Lines: 48 On Tue, Nov 16, 2010 at 7:21 PM, Dirk Brandewie wrote: > > On 11/16/2010 04:39 PM, David Daney wrote: >> >> Thanks for doing this. However I have a few comments... >> >> On 11/16/2010 02:41 PM, dirk.brandewie@gmail.com wrote: >>> >>> From: Dirk Brandewie >>> >>> /* .data section */ >>> #define DATA_DATA \ >>> *(.data) \ >>> @@ -468,7 +482,8 @@ >>> MCOUNT_REC() \ >>> DEV_DISCARD(init.rodata) \ >>> CPU_DISCARD(init.rodata) \ >>> - MEM_DISCARD(init.rodata) >>> + MEM_DISCARD(init.rodata) \ >>> + KERNEL_DTB() >>> >> >> I thought the init.rodata was only for data used by __init things. >> Although the >> current linker scripts do not put it in the section that gets recycled as >> usable >> memory. >> >> IIRC the unflattened version of the device tree has pointers to the >> flattened >> data. Since the device tree nodes are live for the entire kernel >> lifecycle, >> shouldn't the device tree blobs be in non-init memory? >> > > The contents of the blob get copied to allocated memory during > unflatten_device_tree() so the blob that is linked in is no longer needed > after init. Have you written a patch to add this behaviour? The current code doesn't. :-) g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/