Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934318Ab0KQHL2 (ORCPT ); Wed, 17 Nov 2010 02:11:28 -0500 Received: from smtp-vbr16.xs4all.nl ([194.109.24.36]:4827 "EHLO smtp-vbr16.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933055Ab0KQHL1 (ORCPT ); Wed, 17 Nov 2010 02:11:27 -0500 From: Hans Verkuil To: Andrew Chew Subject: Re: [PATCH 1/1] videobuf: Initialize lists in videobuf_buffer. Date: Wed, 17 Nov 2010 08:11:06 +0100 User-Agent: KMail/1.13.5 (Linux/2.6.37-rc2-tschai; KDE/4.4.5; x86_64; ; ) Cc: "'Figo.zhang'" , "pawel@osciak.com" , "linux-media@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <1289939083-27209-1-git-send-email-achew@nvidia.com> <4CE32B9D.1020705@leadcoretech.com> <643E69AA4436674C8F39DCC2C05F763816BB828A40@HQMAIL03.nvidia.com> In-Reply-To: <643E69AA4436674C8F39DCC2C05F763816BB828A40@HQMAIL03.nvidia.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201011170811.06697.hverkuil@xs4all.nl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1479 Lines: 35 On Wednesday, November 17, 2010 02:38:09 Andrew Chew wrote: > > > diff --git a/drivers/media/video/videobuf-dma-contig.c > > b/drivers/media/video/videobuf-dma-contig.c > > > index c969111..f7e0f86 100644 > > > --- a/drivers/media/video/videobuf-dma-contig.c > > > +++ b/drivers/media/video/videobuf-dma-contig.c > > > @@ -193,6 +193,8 @@ static struct videobuf_buffer > > *__videobuf_alloc_vb(size_t size) > > > if (vb) { > > > mem = vb->priv = ((char *)vb) + size; > > > mem->magic = MAGIC_DC_MEM; > > > + INIT_LIST_HEAD(&vb->stream); > > > + INIT_LIST_HEAD(&vb->queue); > > > > i think it no need to be init, it just a list-entry. > > Okay, if that's really the case, then sh_mobile_ceu_camera.c, pxa_camera.c, mx1_camera.c, mx2_camera.c, and omap1_camera.c needs to be fixed to remove that WARN_ON(!list_empty(&vb->queue)); in their videobuf_prepare() methods, because those WARN_ON's are assuming that vb->queue is properly initialized as a list head. > > Which will it be? > These list entries need to be inited. It is bad form to have uninitialized list entries. It is not as if this is a big deal to initialize them properly. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by Cisco -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/