Date: Wed, 17 Nov 2010 08:30:31 +0100
From: Florian Mickler <florian@mickler.org>
To: Andy Whitcroft <apw@canonical.com>
Cc: Audun Hoem <audun.hoem@gmail.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch.pl: fix CAST detection to not screw with
 parens handling
Message-ID: <20101117083031.669b8676@schatten.dmk.lab>
In-Reply-To: <20101103162042.297958c3@schatten.dmk.lab>
References: <AANLkTimA1d88FwGGE-BW4WvyuaFB7xewN_ubko+kj2+X@mail.gmail.com>
	<1288785873-16519-1-git-send-email-florian@mickler.org>
	<20101103162042.297958c3@schatten.dmk.lab>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2096
Lines: 64


Hi Andy, 

did you get this?

Regards,
Flo

On Wed, 3 Nov 2010 16:20:42 +0100
Florian Mickler <florian@mickler.org> wrote:

> On Wed,  3 Nov 2010 13:04:33 +0100
> Florian Mickler <florian@mickler.org> wrote:
> 
> > Casts have to be handled after the last type that is followed by an
> > opening parenthesis is handled.
> 
> That is the wrong fix. I realized now that with that patch we would
> not claim anything as a CAST anymore. Better is probably to only claim
> a CAST if av_pending is not set. Andy, would that work? It seems to be
> alright... Do you have some tests for checkpatch?
> 
> Testing it with the reported line and some other random samples it
> seems to be alright.
> 
> Regards,
> Flo
> 
> >8------------------------------------------------------------------------
> commit 11ed611c647420ea27124faf269d724b4fd3ade4
> Author: Florian Mickler <florian@mickler.org>
> Date:   Wed Nov 3 15:54:26 2010 +0100
> 
>     checkpatch.pl: fix CAST detection
>     
>     We should only claim that something is a cast if we did not encouter a
>     token before, that did set av_pending.
>     
>     This fixes the operator * in the line below  to be detected as
>     binary (vs unary).
>     
>      kmalloc(sizeof(struct alphatrack_ocmd) * true_size, GFP_KERNEL);
>     
>     Reported-by: Audun Hoem <audun.hoem@gmail.com>
>     Signed-off-by: Florian Mickler <florian@mickler.org>
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 90b54d4..06f5c44 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -859,7 +859,7 @@ sub annotate_values {
>  				$av_preprocessor = 0;
>  			}
>  
> -		} elsif ($cur =~ /^(\(\s*$Type\s*)\)/) {
> +		} elsif ($cur =~ /^(\(\s*$Type\s*)\)/ && $av_pending eq '_') {
>  			print "CAST($1)\n" if ($dbg_values > 1);
>  			push(@av_paren_type, $type);
>  			$type = 'C';
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/