Date: Wed, 17 Nov 2010 13:01:28 +0100
From: Andi Kleen <andi@firstfloor.org>
To: Nick Piggin <npiggin@kernel.dk>
Cc: Andi Kleen <andi@firstfloor.org>, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [patch 00/28] [rfc] dcache scaling part 1
Message-ID: <20101117120128.GC23656@basil.fritz.box>
References: <20101116140900.039761100@kernel.dk>
 <877hgcrzgd.fsf@basil.nowhere.org>
 <20101117111947.GA5218@amd>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101117111947.GA5218@amd>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 790
Lines: 20

> I haven't looked at doing semantic patches. I suspect it might be
> a bit too hard to write.
> 
> Really, *most* filesystems do not play silly games with dcache_lock,
> and those that don't are pretty easy. Ones that do need more thought
> than semantic patch could probably apply.

The advantage of using the semantic patch is that it catches
error paths and unusal constructions which are bad for grep better. 
It does not replace hand review and some hand modification of course.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/