Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934054Ab0KQOSs (ORCPT ); Wed, 17 Nov 2010 09:18:48 -0500 Received: from canuck.infradead.org ([134.117.69.58]:35492 "EHLO canuck.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757590Ab0KQOSr convert rfc822-to-8bit (ORCPT ); Wed, 17 Nov 2010 09:18:47 -0500 Subject: Re: [ANNOUNCE] New utility: 'trace' From: Peter Zijlstra To: Ingo Molnar Cc: "Ted Ts'o" , Thomas Gleixner , LKML , Linus Torvalds , Andrew Morton , Steven Rostedt , Arjan van de Ven , Arnaldo Carvalho de Melo , Frederic Weisbecker , Masami Hiramatsu , Tom Zanussi , Mathieu Desnoyers , Li Zefan , Jason Baron , "David S. Miller" , Christoph Hellwig , Pekka Enberg , Lai Jiangshan , Eric Dumazet In-Reply-To: <1290003110.2109.822.camel@laptop> References: <20101117013700.GA3290@thunk.org> <20101117132404.GF27063@elte.hu> <1290001128.2109.785.camel@laptop> <20101117140002.GH27063@elte.hu> <1290003110.2109.822.camel@laptop> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Wed, 17 Nov 2010 15:18:25 +0100 Message-ID: <1290003505.2109.833.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1381 Lines: 31 On Wed, 2010-11-17 at 15:11 +0100, Peter Zijlstra wrote: > The idea was to not let the filter engine work on the trace data (once > its gathered) but on the trace argument right at the beginning of the > tracepoint callchain, since some of the trace data is an expression of > the trace argument (say next->prio instead of next), the trace > expression wouldn't stay invariant, you'd have to write a different > filter for the same effect. > > So I think it would be wise to make this change sooner rather than > later. Also, I see a lot of overlap with the dynamic probes stuff which needs the help of magic dwarves to come up with the right data to gather. Merging the dynamic tracepoint and filter stuff would be nice, there's no way you can express next->prio without the help of these short buggers with large axes. The trouble is that the dynamic tracepoint stuff is privileged for good reasons, try next+0x1000000 and you're out in the woods, priv. only filters otoh just doesn't sound too hot. Another nasty thing is that you actually need to have these dwarves present, which means having the -debug package installed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/