Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934994Ab0KQQbk (ORCPT ); Wed, 17 Nov 2010 11:31:40 -0500 Received: from kroah.org ([198.145.64.141]:48212 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933815Ab0KQQbh (ORCPT ); Wed, 17 Nov 2010 11:31:37 -0500 Date: Wed, 17 Nov 2010 08:17:29 -0800 From: Greg KH To: Emeltchenko Andrei Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm@lists.infradead.org, linux-serial@vger.kernel.org Subject: Re: [PATCH] OMAP: Serial: Define register access modes in LCR Message-ID: <20101117161729.GF10992@kroah.com> References: <1289982712-7309-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1289982712-7309-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1295 Lines: 30 On Wed, Nov 17, 2010 at 10:31:52AM +0200, Emeltchenko Andrei wrote: > From: Andrei Emeltchenko > > Access to some registers depends on register access mode > Three different modes are available for OMAP (at least) > • Operational mode LCR_REG[7] = 0x0 > • Configuration mode A LCR_REG[7] = 0x1 and LCR_REG[7:0]! = 0xBF > • Configuration mode B LCR_REG[7] = 0x1 and LCR_REG[7:0] = 0xBF > > Define access modes and remove redefinitions and magic numbers > in serial drivers (and later in bluetooth driver). > > Signed-off-by: Andrei Emeltchenko > --- > arch/arm/mach-omap2/serial.c | 12 ++++---- > arch/arm/plat-omap/include/plat/omap-serial.h | 9 ------ > drivers/serial/8250.c | 26 +++++++++--------- > drivers/serial/omap-serial.c | 34 ++++++++++++------------ > include/linux/serial_reg.h | 7 +++++ What tree should this go through? THe omap or serial one? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/