Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935082Ab0KQR27 (ORCPT ); Wed, 17 Nov 2010 12:28:59 -0500 Received: from mail-yw0-f46.google.com ([209.85.213.46]:55556 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934912Ab0KQR26 convert rfc822-to-8bit (ORCPT ); Wed, 17 Nov 2010 12:28:58 -0500 From: Kevin Hilman To: Greg KH Cc: Emeltchenko Andrei , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm@lists.infradead.org, linux-serial@vger.kernel.org Subject: Re: [PATCH] OMAP: Serial: Define register access modes in LCR Organization: Deep Root Systems, LLC References: <1289982712-7309-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> <20101117161729.GF10992@kroah.com> Date: Wed, 17 Nov 2010 09:28:52 -0800 In-Reply-To: <20101117161729.GF10992@kroah.com> (Greg KH's message of "Wed, 17 Nov 2010 08:17:29 -0800") Message-ID: <87hbff7tbf.fsf@deeprootsystems.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1558 Lines: 36 Greg KH writes: > On Wed, Nov 17, 2010 at 10:31:52AM +0200, Emeltchenko Andrei wrote: >> From: Andrei Emeltchenko >> >> Access to some registers depends on register access mode >> Three different modes are available for OMAP (at least) >> • Operational mode LCR_REG[7] = 0x0 >> • Configuration mode A LCR_REG[7] = 0x1 and LCR_REG[7:0]! = 0xBF >> • Configuration mode B LCR_REG[7] = 0x1 and LCR_REG[7:0] = 0xBF >> >> Define access modes and remove redefinitions and magic numbers >> in serial drivers (and later in bluetooth driver). >> >> Signed-off-by: Andrei Emeltchenko >> --- >> arch/arm/mach-omap2/serial.c | 12 ++++---- >> arch/arm/plat-omap/include/plat/omap-serial.h | 9 ------ >> drivers/serial/8250.c | 26 +++++++++--------- >> drivers/serial/omap-serial.c | 34 ++++++++++++------------ >> include/linux/serial_reg.h | 7 +++++ > > What tree should this go through? THe omap or serial one? Since this only affects OMAP drivers, we can take this through OMAP. That will also help us avoid conflicts, as we'll hopefully be converting the omap-serial driver to runtime PM for this next merge window as well. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/