Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758709Ab0KQTFr (ORCPT ); Wed, 17 Nov 2010 14:05:47 -0500 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:32757 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758075Ab0KQTFp (ORCPT ); Wed, 17 Nov 2010 14:05:45 -0500 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 67.188.36.105 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/mailhop/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX18+w67CZIImmkLBr7L7ZOnm Date: Wed, 17 Nov 2010 11:05:24 -0800 From: Tony Lindgren To: Greg KH Cc: Kevin Hilman , Emeltchenko Andrei , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm@lists.infradead.org, linux-serial@vger.kernel.org Subject: Re: [PATCH] OMAP: Serial: Define register access modes in LCR Message-ID: <20101117190524.GV9264@atomide.com> References: <1289982712-7309-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> <20101117161729.GF10992@kroah.com> <87hbff7tbf.fsf@deeprootsystems.com> <20101117173115.GA12349@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20101117173115.GA12349@kroah.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1928 Lines: 46 * Greg KH [101117 09:21]: > On Wed, Nov 17, 2010 at 09:28:52AM -0800, Kevin Hilman wrote: > > Greg KH writes: > > > > > On Wed, Nov 17, 2010 at 10:31:52AM +0200, Emeltchenko Andrei wrote: > > >> From: Andrei Emeltchenko > > >> > > >> Access to some registers depends on register access mode > > >> Three different modes are available for OMAP (at least) > > >> • Operational mode LCR_REG[7] = 0x0 > > >> • Configuration mode A LCR_REG[7] = 0x1 and LCR_REG[7:0]! = 0xBF > > >> • Configuration mode B LCR_REG[7] = 0x1 and LCR_REG[7:0] = 0xBF > > >> > > >> Define access modes and remove redefinitions and magic numbers > > >> in serial drivers (and later in bluetooth driver). > > >> > > >> Signed-off-by: Andrei Emeltchenko > > >> --- > > >> arch/arm/mach-omap2/serial.c | 12 ++++---- > > >> arch/arm/plat-omap/include/plat/omap-serial.h | 9 ------ > > >> drivers/serial/8250.c | 26 +++++++++--------- > > >> drivers/serial/omap-serial.c | 34 ++++++++++++------------ > > >> include/linux/serial_reg.h | 7 +++++ > > > > > > What tree should this go through? THe omap or serial one? > > > > Since this only affects OMAP drivers, we can take this through OMAP. > > > > That will also help us avoid conflicts, as we'll hopefully be converting > > the omap-serial driver to runtime PM for this next merge window as well. > > Fine with me, feel free to add: > Acked-by: Greg Kroah-Hartman > > to it. Thanks, will queue for 2.6.38 merge window. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/