Date: Wed, 17 Nov 2010 20:58:43 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Greg KH <greg@kroah.com>
Cc: Eric Cooper <ecc@cmu.edu>, linux-kernel@vger.kernel.org,
        Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH] add netdev led trigger
Message-ID: <20101117195843.GA31357@elf.ucw.cz>
References: <1289768305-1224-1-git-send-email-ecc@cmu.edu>
 <20101117105925.GC1574@ucw.cz>
 <20101117160919.GC10992@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101117160919.GC10992@kroah.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1161
Lines: 39

Hi!

> > > Add a netdev LED trigger for all Blinkenlights lovers...
> > > Originally taken from https://dev.openwrt.org/ticket/2776
> > > Slightly updated for 2.6.24 by Mickey Lauer <mickey@openmoko.org>
> > > and for 2.6.36 by Eric Cooper <ecc@cmu.edu>
> > 
> > Nice!
> > 
> > > +/*
> > > + * Configurable sysfs attributes:
> > > + *
> > > + * device_name - network device name to monitor
> > > + *
> > > + * interval - duration of LED blink, in milliseconds
> > 
> > This needs to go to Doc/ somewhere.
> 
> Documentation/ABI is the correct place for it.

I was hoping you'd comment on the ABI itself, too. It uses 

echo "foo bar baz" > file

to enable/disable specific events to be "displayed". More traditional
interface would be 

echo disable > file_foo

...
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/