Date: Wed, 17 Nov 2010 15:06:14 -0500
From: Eric Cooper <ecc@cmu.edu>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add netdev led trigger
Message-ID: <20101117200614.GK15096@localhost>
Mail-Followup-To: linux-kernel@vger.kernel.org
References: <1289768305-1224-1-git-send-email-ecc@cmu.edu>
 <20101117105925.GC1574@ucw.cz>
 <20101117160919.GC10992@kroah.com>
 <20101117195843.GA31357@elf.ucw.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101117195843.GA31357@elf.ucw.cz>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 855
Lines: 23

On Wed, Nov 17, 2010 at 08:58:43PM +0100, Pavel Machek wrote:
> I was hoping you'd comment on the ABI itself, too. It uses 
> 
> echo "foo bar baz" > file
> 
> to enable/disable specific events to be "displayed". More traditional
> interface would be 
> 
> echo disable > file_foo

The main arguments for using the single "mode" file are:
1. that's how it was implemented for OpenWrt, and there's a fair
   amount of userland (web admin tools, etc.) that groks it
2. it's only specifying a set of three possible values -- separate
   files seem like overkill

-- 
Eric Cooper             e c c @ c m u . e d u
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/