Subject: Re: [PATCH 1/2] drivers: regulator: core: use pr_fmt
From: Joe Perches <joe@perches.com>
To: Daniel Walker <dwalker@codeaurora.org>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
        Mark Brown <broonie@opensource.wolfsonmicro.com>,
        linux-kernel@vger.kernel.org, bleong@codeaurora.org
In-Reply-To: <1290036628-9928-1-git-send-email-dwalker@codeaurora.org>
References: <1290036628-9928-1-git-send-email-dwalker@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
Date: Wed, 17 Nov 2010 16:29:54 -0800
Message-ID: <1290040194.28741.324.camel@Joe-Laptop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1309
Lines: 35

On Wed, 2010-11-17 at 15:30 -0800, Daniel Walker wrote:
> This adds a pr_fmt line which uses the __func__ macro. I also
> convert the current pr_ lines to remove their __func__ usage.
[]
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> @@ -765,8 +767,8 @@ static int machine_constraints_voltage(struct regulator_dev *rdev,
>  
>  		/* else require explicit machine-level constraints */
>  		if (cmin <= 0 || cmax <= 0 || cmax < cmin) {
> -			pr_err("%s: %s '%s' voltage constraints\n",
> -				       __func__, "invalid", name);
> +			pr_err("%s '%s' voltage constraints\n", "invalid",
> +				name);

Using a separate pointer for invalid and unsupportable
doesn't save much text space and is very hard to grep.

I think it's more intelligible as:

			pr_err("%s: Invalid voltage constraints\n", name);

> -			pr_err("%s: %s '%s' voltage constraints\n",
> -				       __func__, "unsupportable", name);
> +			pr_err("%s '%s' voltage constraints\n", "unsupportable",
> +				name);

and
			pr_err("%s: Unsupportable voltage constraints\n", name);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/