Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753725Ab0KRGtA (ORCPT ); Thu, 18 Nov 2010 01:49:00 -0500 Received: from mga02.intel.com ([134.134.136.20]:32425 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751254Ab0KRGs7 (ORCPT ); Thu, 18 Nov 2010 01:48:59 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.59,216,1288594800"; d="scan'208";a="678649032" Date: Thu, 18 Nov 2010 13:27:50 +0800 From: Shaohui Zheng To: Paul Mundt Cc: David Rientjes , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, haicheng.li@linux.intel.com, ak@linux.intel.com, shaohui.zheng@linux.intel.com, Yinghai Lu , Haicheng Li Subject: Re: [2/8,v3] NUMA Hotplug Emulator: infrastructure of NUMA hotplug emulation Message-ID: <20101118052750.GD2408@shaohui> References: <20101117020759.016741414@intel.com> <20101117021000.568681101@intel.com> <20101117075128.GA30254@shaohui> <20101118041407.GA2408@shaohui> <20101118062715.GD17539@linux-sh.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101118062715.GD17539@linux-sh.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1572 Lines: 33 On Thu, Nov 18, 2010 at 03:27:15PM +0900, Paul Mundt wrote: > On Thu, Nov 18, 2010 at 12:14:07PM +0800, Shaohui Zheng wrote: > > On Wed, Nov 17, 2010 at 01:10:50PM -0800, David Rientjes wrote: > > > The idea that I've proposed (and you've apparently thought about and even > > > implemented at one point) is much more powerful than that. We need not > > > query the state of hidden nodes that we've setup at boot but can rather > > > use the amount of hidden memory to setup the nodes in any way that we want > > > at runtime (various sizes, interleaved node ids, etc). > > > > yes, if we select your proposal. we just mark all the nodes as POSSIBLE node. > > there is no hidden nodes any more. the node will be created after add memory > > to the node first time. > > > This is roughly what I had in mind in my N_HIDDEN review, so I quite > favour this approach. Our testing shows that it is a feasible approach, and it works well. however, there is still a problem which we should worry about. in our draft patch, we re-setup nr_node_ids when CONFIG_ARCH_MEMORY_PROBE enabled and mem=XXX was specified in grub. we set nr_node_ids as MAX_NUMNODES + 1, because we do not know how many nodes will be hot-added through memory/probe interface. it might be a little wasting of memory. -- Thanks & Regards, Shaohui -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/