Message-ID: <4CE4E841.9020107@kernel.org>
Date: Thu, 18 Nov 2010 09:48:01 +0100
From: Tejun Heo <tj@kernel.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.12) Gecko/20101027 Lightning/1.0b2 Thunderbird/3.1.6
MIME-Version: 1.0
To: Ingo Molnar <mingo@elte.hu>
CC: linux-kernel@vger.kernel.org, mingo@redhat.com, tglx@linutronix.de,
        hpa@zytor.com, x86@kernel.org, eric.dumazet@gmail.com,
        yinghai@kernel.org
Subject: Re: [PATCH 4/9 UPDATED-1] x86: Initialize 32bit logical apicid mapping
 early during boot
References: <1289473363-29440-1-git-send-email-tj@kernel.org> <1289473363-29440-5-git-send-email-tj@kernel.org> <4CDD17EC.8000507@kernel.org> <20101118083045.GB26398@elte.hu> <4CE4E655.30207@kernel.org> <20101118084257.GF26398@elte.hu>
In-Reply-To: <20101118084257.GF26398@elte.hu>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1345
Lines: 33

Hello,

On 11/18/2010 09:42 AM, Ingo Molnar wrote:
> This is a very sensitive area of code that tends to blow up in nasty
> ways. So when we do changes here we want them super-finegrained. If
> you split it up into 30 reasonable patches - no problem at
> all. (here up to 5 would suffice i think)

I'll probably split it to three or four.  That said, I don't really
think it would help bisection.  But, anyways, no problem.

>> Yeah, what they do is ugly.  It gets less uglier after the patchset.
>> I'll see if some of them can be dropped but I don't think putting them
>> inside ifdef'd inline functions necessarily improves things.  It often
>> just makes things more difficult to follow.
> 
> Can we remove them? Or does it make any sense on the 64-bit side?

Those are the parts where 32 and 64 actually differ.  On 64, the
mapping between physical and logical are fixed (at least in the
generic arch code) which isn't true on 32, so it doesn't make much
sense for 64.  For now, I would suggest leaving them ugly.  At least
they're now properly localized after the patchset.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/