Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755630Ab0KRIxE (ORCPT ); Thu, 18 Nov 2010 03:53:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39427 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750975Ab0KRIxC (ORCPT ); Thu, 18 Nov 2010 03:53:02 -0500 Date: Thu, 18 Nov 2010 09:52:51 +0100 (CET) From: Lukas Czerner X-X-Sender: lukas@dhcp-lab-213.englab.brq.redhat.com To: "Darrick J. Wong" cc: "Theodore Ts'o" , Lukas Czerner , Eric Sandeen , "Patrick J. LoPresti" , linux-kernel , linux-ext4 , Mingming Cao , Jan Kara Subject: Re: [PATCH] ext3: Return error code from generic_check_addressable In-Reply-To: <20101116225744.GD18195@tux1.beaverton.ibm.com> Message-ID: References: <20101115214831.GA18195@tux1.beaverton.ibm.com> <4CE1AC38.9040201@redhat.com> <20101115230346.GB18195@tux1.beaverton.ibm.com> <20101116225744.GD18195@tux1.beaverton.ibm.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1382 Lines: 46 On Tue, 16 Nov 2010, Darrick J. Wong wrote: > ext3: Return error code from generic_check_accessible > > ext3_fill_super should return the error code that generic_check_accessible > returns when an error condition occurs. > > Signed-off-by: Darrick J. Wong > --- > > fs/ext3/super.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/fs/ext3/super.c b/fs/ext3/super.c > index 2fedaf8..960629b 100644 > --- a/fs/ext3/super.c > +++ b/fs/ext3/super.c > @@ -1842,13 +1842,15 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) > goto failed_mount; > } > > - if (generic_check_addressable(sb->s_blocksize_bits, > - le32_to_cpu(es->s_blocks_count))) { > + err = generic_check_addressable(sb->s_blocksize_bits, > + le32_to_cpu(es->s_blocks_count)); > + if (err) { > ext3_msg(sb, KERN_ERR, > "error: filesystem is too large to mount safely"); > if (sizeof(sector_t) < 8) > ext3_msg(sb, KERN_ERR, > "error: CONFIG_LBDAF not enabled"); > + ret = err; > goto failed_mount; > } > > Add Jan Kara to cc list. -Lukas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/