Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756432Ab0KRJtq (ORCPT ); Thu, 18 Nov 2010 04:49:46 -0500 Received: from mail-qw0-f46.google.com ([209.85.216.46]:51110 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756290Ab0KRJto convert rfc822-to-8bit (ORCPT ); Thu, 18 Nov 2010 04:49:44 -0500 MIME-Version: 1.0 X-Originating-IP: [81.245.230.134] In-Reply-To: <1290072314-31155-2-git-send-email-trenn@suse.de> References: <1290072314-31155-1-git-send-email-trenn@suse.de> <1290072314-31155-2-git-send-email-trenn@suse.de> Date: Thu, 18 Nov 2010 10:44:42 +0100 Message-ID: Subject: Re: [PATCH 1/3] PERF: Do not export power_frequency, but power_start event From: Jean Pihet To: Thomas Renninger Cc: arjan@linux.intel.com, mingo@elte.hu, rjw@sisk.pl, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1876 Lines: 60 On Thu, Nov 18, 2010 at 10:25 AM, Thomas Renninger wrote: > power_frequency moved to drivers/cpufreq/cpufreq.c which has > to be compiled in, no need to export it. > > intel_idle can a be module though... > > Signed-off-by: Thomas Renninger > CC: Jean Pihet > CC: Arjan van de Ven > CC: Ingo Molnar > CC: linux-kernel@vger.kernel.org Ok for me! Acked-by: Jean Pihet Note the ti.com email address to be used for Sign-offs and Acks. > --- > ?drivers/idle/intel_idle.c ? | ? ?2 -- > ?kernel/trace/power-traces.c | ? ?2 +- > ?2 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c > index 41665d2..3c95325 100644 > --- a/drivers/idle/intel_idle.c > +++ b/drivers/idle/intel_idle.c > @@ -220,9 +220,7 @@ static int intel_idle(struct cpuidle_device *dev, struct cpuidle_state *state) > ? ? ? ?kt_before = ktime_get_real(); > > ? ? ? ?stop_critical_timings(); > -#ifndef MODULE > ? ? ? ?trace_power_start(POWER_CSTATE, (eax >> 4) + 1, cpu); > -#endif > ? ? ? ?if (!need_resched()) { > > ? ? ? ? ? ? ? ?__monitor((void *)¤t_thread_info()->flags, 0, 0); > diff --git a/kernel/trace/power-traces.c b/kernel/trace/power-traces.c > index a22582a..0e0497d 100644 > --- a/kernel/trace/power-traces.c > +++ b/kernel/trace/power-traces.c > @@ -13,5 +13,5 @@ > ?#define CREATE_TRACE_POINTS > ?#include > > -EXPORT_TRACEPOINT_SYMBOL_GPL(power_frequency); > +EXPORT_TRACEPOINT_SYMBOL_GPL(power_start); > > -- > 1.6.3 > > Thanks, Jean -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/