Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758287Ab0KROJT (ORCPT ); Thu, 18 Nov 2010 09:09:19 -0500 Received: from hera.kernel.org ([140.211.167.34]:41381 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758262Ab0KROJQ (ORCPT ); Thu, 18 Nov 2010 09:09:16 -0500 Date: Thu, 18 Nov 2010 14:08:40 GMT From: tip-bot for Alex Shi Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com, a.p.zijlstra@chello.nl, ncrao@google.com, efault@gmx.de, alex.shi@intel.com, tglx@linutronix.de, mingo@elte.hu Reply-To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, ncrao@google.com, a.p.zijlstra@chello.nl, efault@gmx.de, alex.shi@intel.com, tglx@linutronix.de, mingo@elte.hu In-Reply-To: <1289928732.5169.211.camel@maggy.simson.net> References: <1289928732.5169.211.camel@maggy.simson.net> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/urgent] sched: Fix volanomark performance regression Message-ID: Git-Commit-ID: b5482cfa1c95a188b3054fa33274806add91bbe5 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.3 (hera.kernel.org [127.0.0.1]); Thu, 18 Nov 2010 14:08:41 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1590 Lines: 42 Commit-ID: b5482cfa1c95a188b3054fa33274806add91bbe5 Gitweb: http://git.kernel.org/tip/b5482cfa1c95a188b3054fa33274806add91bbe5 Author: Alex Shi AuthorDate: Tue, 16 Nov 2010 17:34:02 +0800 Committer: Ingo Molnar CommitDate: Thu, 18 Nov 2010 13:11:43 +0100 sched: Fix volanomark performance regression Commit fab4762 triggers excessive idle balancing, causing a ~30% loss in volanomark throughput. Remove idle balancing throttle reset. Originally-by: Alex Shi Signed-off-by: Mike Galbraith Acked-by: Nikhil Rao Signed-off-by: Peter Zijlstra LKML-Reference: <1289928732.5169.211.camel@maggy.simson.net> Signed-off-by: Ingo Molnar --- kernel/sched_fair.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c index 52ab113..ba0556d 100644 --- a/kernel/sched_fair.c +++ b/kernel/sched_fair.c @@ -1758,10 +1758,6 @@ static void pull_task(struct rq *src_rq, struct task_struct *p, set_task_cpu(p, this_cpu); activate_task(this_rq, p, 0); check_preempt_curr(this_rq, p, 0); - - /* re-arm NEWIDLE balancing when moving tasks */ - src_rq->avg_idle = this_rq->avg_idle = 2*sysctl_sched_migration_cost; - this_rq->idle_stamp = 0; } /* -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/