Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759918Ab0KRQxh (ORCPT ); Thu, 18 Nov 2010 11:53:37 -0500 Received: from mga02.intel.com ([134.134.136.20]:45310 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754471Ab0KRQxf convert rfc822-to-8bit (ORCPT ); Thu, 18 Nov 2010 11:53:35 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.59,217,1288594800"; d="scan'208";a="678791261" From: "Berg, Johannes" To: Michal Hocko CC: LKML , "akpm@linux-foundation.org" Date: Thu, 18 Nov 2010 16:52:59 +0000 Subject: RE: 5ada28bf76752 causes compilation error if !CONFIG_LEDS_CLASS Thread-Topic: 5ada28bf76752 causes compilation error if !CONFIG_LEDS_CLASS Thread-Index: AcuG+hfTN6PWkyK1QQqNwZbMZU3bDwARtd1A Message-ID: References: <20101116142027.GC19247@tiehlicka.suse.cz> <20101118082454.GC15928@tiehlicka.suse.cz> In-Reply-To: <20101118082454.GC15928@tiehlicka.suse.cz> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1714 Lines: 43 > > > it seems that your patch (5ada28bf76752e33dce3d807bf0dfbe6d1b943ad) > > > causes the following compilatation error: > > > LD .tmp_vmlinux1 > > > drivers/built-in.o: In function `led_trigger_set': > > > drivers/leds/led-triggers.c:116: undefined reference to > > > `led_brightness_set' > > > make[1]: *** [.tmp_vmlinux1] Error 1 > > > > > > AFAICS, led_brightness_set is defined in drivers/leds/led-class.c > which > > > is compiled only if CONFIG_LEDS_CLASS is configured which is not my > > > case (after make oldconfig with all default values from 37-rc1). > > > > > > I am not sure what is the right solution whether > CONFIG_LEDS_TRIGGERS > > > should depend on CONFIG_LEDS_CLASS or the patch should be reverted. > > > > > > My config is attached, if somebody need it. > > > > Hmm, we did find that, and I made a patch to fix up the Kconfig, that > apparently hasn't made it in? Bit confused now. > > Does this mean that I should enable CONFIG_LEDS_CLASS to work around > the issue for this moment? I think that'd be easiest, yes. johannes -------------------------------------------------------------------------------------- Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/