Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757942Ab0KRTvn (ORCPT ); Thu, 18 Nov 2010 14:51:43 -0500 Received: from e39.co.us.ibm.com ([32.97.110.160]:41191 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756278Ab0KRTvl (ORCPT ); Thu, 18 Nov 2010 14:51:41 -0500 Date: Thu, 18 Nov 2010 13:51:17 -0600 From: Sonny Rao To: Joe Carnuccio Cc: Sonny Rao , "linux-scsi@vger.kernel.org" , Milton Miller , Andrew Vasquez , Linux Driver , "James E.J. Bottomley" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] [RFC] qla2xxx: Change parameter permissions in sysfs Message-ID: <20101118195117.GQ32203@us.ibm.com> References: <1290078346-3521-1-git-send-email-sonnyrao@linux.vnet.ibm.com> <5E4F49720D0BAD499EE1F01232234BA872242EF99D@AVEXMB1.qlogic.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5E4F49720D0BAD499EE1F01232234BA872242EF99D@AVEXMB1.qlogic.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 860 Lines: 21 On Thu, Nov 18, 2010 at 11:33:12AM -0800, Joe Carnuccio wrote: > Sonny, > > The qla2xxx parameters that already had write permission do not require rebinding. > > The qla2xxx parameters that require rebinding have read only permission and do not require write persmission since these are the ones whose value can be set on driver load. > > The fact that some of the qla2xxx parameters had permission set to S_IRUGO|S_IRUSR was a "typo", it should have been S_IRUGO only, I have been in the process of addressing this in our drivers (here at QLogic). > > Thanks. > > -Joe Ok thanks for clearing that up Sonny -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/