Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760561Ab0KRVLu (ORCPT ); Thu, 18 Nov 2010 16:11:50 -0500 Received: from swampdragon.chaosbits.net ([90.184.90.115]:12093 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760486Ab0KRVLt (ORCPT ); Thu, 18 Nov 2010 16:11:49 -0500 Date: Thu, 18 Nov 2010 21:59:07 +0100 (CET) From: Jesper Juhl To: Russell King cc: Linus Torvalds , linux-scsi@vger.kernel.org, "James E.J. Bottomley" , linux-kernel@vger.kernel.org, Eric Youngdale , "David S. Miller" , Mike Anderson , Andrew Morton Subject: Re: [PATCH][resend][SCSI] Reduce number of sequential pointer derefs in scsi_error.c and reduce size as well In-Reply-To: <20101118210642.GA24236@flint.arm.linux.org.uk> Message-ID: References: <20101118210642.GA24236@flint.arm.linux.org.uk> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1278 Lines: 33 On Thu, 18 Nov 2010, Russell King wrote: > On Thu, Nov 18, 2010 at 09:49:29PM +0100, Jesper Juhl wrote: > > @@ -617,10 +623,10 @@ static int scsi_try_bus_device_reset(struct scsi_cmnd *scmd) > > > > static int __scsi_try_to_abort_cmd(struct scsi_cmnd *scmd) > > { > > - if (!scmd->device->host->hostt->eh_abort_handler) > > - return FAILED; > > - > > - return scmd->device->host->hostt->eh_abort_handler(scmd); > > + struct scsi_host_template *hostt = scmd->device->host->hostt; > > + if (!hostt->eh_abort_handler) > > + return FAILED; > > + return hostt->eh_abort_handler(scmd); > > Not that I have much to do with SCSI anymore... I spotted the above. > Is there any particular reason for using spaces to indent here rather > than our usual tabs? > No. That was me and Emacs having a slight disagreement (see the mail I just sent)... -- Jesper Juhl http://www.chaosbits.net/ Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/