Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760729Ab0KRVuP (ORCPT ); Thu, 18 Nov 2010 16:50:15 -0500 Received: from smtp-out-249.synserver.de ([212.40.180.249]:1049 "HELO smtp-out-247.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with SMTP id S1760707Ab0KRVuM (ORCPT ); Thu, 18 Nov 2010 16:50:12 -0500 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: markus@trippelsdorf.de X-SynServer-PPID: 7919 Date: Thu, 18 Nov 2010 22:50:08 +0100 From: Markus Trippelsdorf To: Mark Lord Cc: Jamie Lokier , Jeff Moyer , James Bottomley , Christoph Hellwig , Matthew Wilcox , Josef Bacik , Lukas Czerner , tytso@mit.edu, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, sandeen@redhat.com Subject: Re: [PATCH 1/2] fs: Do not dispatch FITRIM through separate super_operation Message-ID: <20101118215008.GA1556@arch.trippelsdorf.de> References: <1290065809-3976-1-git-send-email-lczerner@redhat.com> <20101118130630.GJ6178@parisc-linux.org> <20101118134804.GN5618@dhcp231-156.rdu.redhat.com> <20101118141957.GK6178@parisc-linux.org> <20101118142918.GA18510@infradead.org> <1290100750.3041.72.camel@mulgrave.site> <20101118180557.GU22787@shareable.org> <20101118193255.GE1594@arch.trippelsdorf.de> <4CE59E86.1080603@teksavvy.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4CE59E86.1080603@teksavvy.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 915 Lines: 23 On 2010.11.18 at 16:45 -0500, Mark Lord wrote: > On 10-11-18 02:32 PM, Markus Trippelsdorf wrote: > >On 2010.11.18 at 18:05 +0000, Jamie Lokier wrote: > >>Online trim may be slow, but offline would be awfully inconvenient > >>when an fs is big and needed for a live system, or when it's your root fs. > > > >You can call FITRIM from a running system. Infact I run it once per week > >as a cron job on my (mounted) root fs. > > > Ditto for wiper.sh. But I always thought that wiper has no access to the filesystem internals. So there is always a chance that you write to a sector that wiper.sh is currently trimming. FITRIM should be safer in this regard. -- Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/