Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760694Ab0KRVwV (ORCPT ); Thu, 18 Nov 2010 16:52:21 -0500 Received: from kroah.org ([198.145.64.141]:35302 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755654Ab0KRVwT (ORCPT ); Thu, 18 Nov 2010 16:52:19 -0500 Date: Thu, 18 Nov 2010 13:46:19 -0800 From: Greg KH To: Vladislav Bolkhovitin Cc: Richard Williams , Bart Van Assche , Boaz Harrosh , FUJITA Tomonori , Mike Christie , "linux-scsi@vger.kernel.org" , Dmitry Torokhov , "linux-kernel@vger.kernel.org" , James Bottomley , scst-devel , Hannes Reinecke , Andy Yan , Andrew Morton , Vu Pham , Linus Torvalds , Joel Becker Subject: Re: [Scst-devel] [PATCH 8/19]: SCST SYSFS interface implementation Message-ID: <20101118214619.GA29097@kroah.com> References: <20101112012315.GE17097@core.coreip.homeip.net> <4CDEC8D2.8080101@vlnb.net> <20101113235938.GA1827@kroah.com> <4CE1017E.4090409@panasas.com> <20101115161620.GB5981@kroah.com> <4CE16B8E.1000300@panasas.com> <8985DEAF-4227-4629-B90A-938D2BA3534E@etechsoft.com> <4CE2846C.6070501@vlnb.net> <4CE59482.3050002@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4CE59482.3050002@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1004 Lines: 25 On Fri, Nov 19, 2010 at 12:02:58AM +0300, Vladislav Bolkhovitin wrote: > Since nobody objected, Greg, could you consider to ACK SCST SYSFS > management interface in /sys/kernel/scst_tgt/, please? Please find the > SCST SYSFS ABI documentation file you requested below. No, sorry, again, you should not be using kobjects, and do not polute the main /sys/kernel/ namespace with this. Use 'struct device' please, that is what it is there for, and is what the rest of the kernel is using. And use the rest of the driver/bus/device infrastructure as your model will work with it just fine. Yes, I know you said you didn't think you could use it, and that your code was different than everyone elses, but I still do not believe it, sorry. good luck, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/