Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760765Ab0KRWK7 (ORCPT ); Thu, 18 Nov 2010 17:10:59 -0500 Received: from complete.lackof.org ([198.49.126.79]:36963 "EHLO complete.lackof.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754334Ab0KRWK6 (ORCPT ); Thu, 18 Nov 2010 17:10:58 -0500 X-Greylist: delayed 423 seconds by postgrey-1.27 at vger.kernel.org; Thu, 18 Nov 2010 17:10:58 EST From: dann frazier To: ocfs2-devel@oss.oracle.com Cc: linux-kernel@vger.kernel.org Subject: [PATCH] [OCFS2] ocfs2_connection_find() returns pointer to bad structure Date: Thu, 18 Nov 2010 15:03:09 -0700 Message-Id: <1290117789-3915-1-git-send-email-dann.frazier@canonical.com> X-Mailer: git-send-email 1.7.2.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1327 Lines: 40 If ocfs2_live_connection_list is empty, ocfs2_connection_find() will return a pointer to the LIST_HEAD, cast as a ocfs2_live_connection. This can cause an oops when ocfs2_control_send_down() dereferences c->oc_conn: Call Trace: [] ocfs2_control_message+0x28c/0x2b0 [ocfs2_stack_user] [] ocfs2_control_write+0x35/0xb0 [ocfs2_stack_user] [] vfs_write+0xb8/0x1a0 [] ? do_page_fault+0x153/0x3b0 [] sys_write+0x51/0x80 [] system_call_fastpath+0x16/0x1b Fix by explicitly returning NULL if no match is found. Signed-off-by: dann frazier --- fs/ocfs2/stack_user.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ocfs2/stack_user.c b/fs/ocfs2/stack_user.c index 252e7c8..a5ebe42 100644 --- a/fs/ocfs2/stack_user.c +++ b/fs/ocfs2/stack_user.c @@ -190,7 +190,7 @@ static struct ocfs2_live_connection *ocfs2_connection_find(const char *name) return c; } - return c; + return NULL; } /* -- 1.7.2.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/