Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760749Ab0KRW3j (ORCPT ); Thu, 18 Nov 2010 17:29:39 -0500 Received: from cain.qlogic.com ([198.70.193.223]:60708 "EHLO cain.qlc.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756730Ab0KRW3i (ORCPT ); Thu, 18 Nov 2010 17:29:38 -0500 Date: Thu, 18 Nov 2010 14:17:14 -0800 From: Ron Mercer To: Sonny Rao Cc: "netdev@vger.kernel.org" , Milton Miller , Linux Driver , "linux-kernel@vger.kernel.org" , "sonnyrao@linux.vnet.ibm.com" Subject: Re: [PATCH] qlge: Fix incorrect usage of module parameters and netdev msg level Message-ID: <20101118221713.GB14333@linux-ox1b.qlogic.org> Mail-Followup-To: Sonny Rao , "netdev@vger.kernel.org" , Milton Miller , Linux Driver , "linux-kernel@vger.kernel.org" , "sonnyrao@linux.vnet.ibm.com" References: <20101118215002.GS32203@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101118215002.GS32203@us.ibm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 850 Lines: 19 On Thu, Nov 18, 2010 at 01:50:02PM -0800, Sonny Rao wrote: > Driver appears to be mistaking the permission field with default value > in the case of debug and qlge_irq_type. > > Driver is also passing debug as a bitmask into netif_msg_init() > which wants a number of bits. Ron Mercer suggests we should > change this to pass in -1 so the defaults get used instead, > which makes the default much less verbose. > > Signed-off-by: Milton Miller > Signed-off-by: Sonny Rao Milton/Sonny, Did you happen to test this to see if the log output was the same? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/