Date: Thu, 18 Nov 2010 17:12:12 -0600
From: Sonny Rao <sonnyrao@us.ibm.com>
To: ron.mercer@qlogic.com, "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Milton Miller <miltonm@bga.com>,
        Linux Driver <Linux-Driver@qlogic.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "sonnyrao@linux.vnet.ibm.com" <sonnyrao@linux.vnet.ibm.com>
Subject: Re: [PATCH] qlge: Fix incorrect usage of module parameters and
	netdev msg level
Message-ID: <20101118231212.GU32203@us.ibm.com>
References: <20101118215002.GS32203@us.ibm.com>
 <20101118221713.GB14333@linux-ox1b.qlogic.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101118221713.GB14333@linux-ox1b.qlogic.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1167
Lines: 27

On Thu, Nov 18, 2010 at 02:17:14PM -0800, Ron Mercer wrote:
> On Thu, Nov 18, 2010 at 01:50:02PM -0800, Sonny Rao wrote:
> > Driver appears to be mistaking the permission field with default value
> > in the case of debug and qlge_irq_type.
> > 
> > Driver is also passing debug as a bitmask into netif_msg_init()
> > which wants a number of bits.  Ron Mercer suggests we should
> > change this to pass in -1 so the defaults get used instead,
> > which makes the default much less verbose.
> > 
> > Signed-off-by: Milton Miller <miltonm@bga.com>
> > Signed-off-by: Sonny Rao <sonnyrao@linux.vnet.ibm.com>
> 
> Milton/Sonny,
> Did you happen to test this to see if the log output was the same? 

Well, I haven't tried the -1 but I suspect it is much more sane than
the 15 I had before because that was excessively verbose and I always
ended up turning it down.  I'll try it out and see.

-- 
Sonny Rao, LTC OzLabs, BML team
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/