Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751569Ab0KSHRL (ORCPT ); Fri, 19 Nov 2010 02:17:11 -0500 Received: from mail-ww0-f44.google.com ([74.125.82.44]:35316 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750754Ab0KSHRJ convert rfc822-to-8bit (ORCPT ); Fri, 19 Nov 2010 02:17:09 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=JB/MF0u9e9OvkSkEqnrXLax+vhU+qI9zxISy0218Mmu1nF16frdeUTszuw5GP/AmX1 WUHlfpRQsmRDzeKrn5Lqbc8qMqVPRyKFkKxYreXcDBA+GHqzPdYpJSZM2agckprbWrHY YT/Rn2U/wSqsIemE2BTsq2L6rCJISrXYV5b5U= MIME-Version: 1.0 In-Reply-To: <1290072458.18450.1.camel@e102144-lin.cambridge.arm.com> References: <1290063401-25440-1-git-send-email-dengcheng.zhu@gmail.com> <1290063401-25440-6-git-send-email-dengcheng.zhu@gmail.com> <1290072458.18450.1.camel@e102144-lin.cambridge.arm.com> Date: Fri, 19 Nov 2010 15:16:38 +0800 Message-ID: Subject: Re: [PATCH 5/5] MIPS/Perf-events: Use unsigned delta for right shift in event update From: Deng-Cheng Zhu To: Will Deacon Cc: ralf@linux-mips.org, a.p.zijlstra@chello.nl, fweisbec@gmail.com, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, wuzhangjin@gmail.com, paulus@samba.org, mingo@elte.hu, acme@redhat.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2221 Lines: 57 Thanks. The commit you pointed out was also in this patch set (#3). But I think the return value should stick to 0, not 1. Something out of my consideration? Deng-Cheng 2010/11/18 Will Deacon : > On Thu, 2010-11-18 at 06:56 +0000, Deng-Cheng Zhu wrote: >> Leverage the commit for ARM by Will Deacon: >> >> 446a5a8b1eb91a6990e5c8fe29f14e7a95b69132 >> ? ? ? ? ARM: 6205/1: perf: ensure counter delta is treated as unsigned >> >> Signed-off-by: Deng-Cheng Zhu >> --- >> ?arch/mips/kernel/perf_event.c | ? ?2 +- >> ?1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/arch/mips/kernel/perf_event.c b/arch/mips/kernel/perf_event.c >> index 345232a..0f1cdf5 100644 >> --- a/arch/mips/kernel/perf_event.c >> +++ b/arch/mips/kernel/perf_event.c >> @@ -169,7 +169,7 @@ static void mipspmu_event_update(struct perf_event *event, >> ? ? ? ? unsigned long flags; >> ? ? ? ? int shift = 64 - TOTAL_BITS; >> ? ? ? ? s64 prev_raw_count, new_raw_count; >> - ? ? ? s64 delta; >> + ? ? ? u64 delta; >> >> ?again: >> ? ? ? ? prev_raw_count = local64_read(&hwc->prev_count); >> -- >> 1.7.1 > > Acked-by: Will Deacon > > You might also want to look at commit 65b4711f if you based > the MIPS port on the old ARM code. > > Thanks, > > Will > > -- > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. ?Thank you. > > -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. ?Thank you. > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/