Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753148Ab0KSLGX (ORCPT ); Fri, 19 Nov 2010 06:06:23 -0500 Received: from mga14.intel.com ([143.182.124.37]:19428 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752867Ab0KSLGW (ORCPT ); Fri, 19 Nov 2010 06:06:22 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.59,222,1288594800"; d="scan'208";a="350816807" Date: Fri, 19 Nov 2010 10:46:31 +0000 From: Alan Cox To: Axel Lin Cc: linux-kernel , Andrew Morton , Liu Hong , Kalhan Trisal Subject: Re: [PATCH] misc/isl29020: Remove incorrect kfree in isl29020_remove() Message-ID: <20101119104631.2c28da00@linux.intel.com> In-Reply-To: <1290144437.23599.4.camel@mola> References: <1290144437.23599.4.camel@mola> Organization: Intel X-Mailer: Claws Mail 3.7.5 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 601 Lines: 17 On Fri, 19 Nov 2010 13:27:17 +0800 Axel Lin wrote: > struct als_data *data is not used in this driver at all. > > Also add a missing ">" character for MODULE_AUTHOR. > > Signed-off-by: Axel Lin Acked-by: Alan Cox It stayed as NULL so the kfree was fine but it definitely wants removing -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/