Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753974Ab0KSMCx (ORCPT ); Fri, 19 Nov 2010 07:02:53 -0500 Received: from casper.infradead.org ([85.118.1.10]:51098 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753543Ab0KSMCv convert rfc822-to-8bit (ORCPT ); Fri, 19 Nov 2010 07:02:51 -0500 Subject: Re: [PATCH 0/2] Generic hardware error reporting support From: Peter Zijlstra To: huang ying Cc: Huang Ying , Len Brown , linux-kernel@vger.kernel.org, Andi Kleen , linux-acpi@vger.kernel.org, Andrew Morton , Linus Torvalds , Ingo Molnar , Mauro Carvalho Chehab , Borislav Petkov , Thomas Gleixner , Tony Luck In-Reply-To: References: <1290154233-28695-1-git-send-email-ying.huang@intel.com> <1290165768.2109.1537.camel@laptop> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Fri, 19 Nov 2010 13:02:53 +0100 Message-ID: <1290168173.2109.1565.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1649 Lines: 39 On Fri, 2010-11-19 at 19:54 +0800, huang ying wrote: > > On Fri, Nov 19, 2010 at 7:22 PM, Peter Zijlstra wrote: > > On Fri, 2010-11-19 at 16:10 +0800, Huang Ying wrote: > >> Hi, Len, > >> > >> This is used by APEI ERST and GEHS. But it is a generic hardware > >> error reporting mechanism and can be used by other hardware error > >> reporting mechanisms such as EDAC, PCIe AER, Machine Check, etc. > >> > >> The patchset is split from the original APEI patchset to make it > >> explicit that this is a generic mechanism, not APEI specific bits. > >> > >> [PATCH 1/2] Generic hardware error reporting mechanism > >> [PATCH 2/2] Hardware error record persistent support > > > > You call it generic, does that mean the EDAC guys agree, does it work on > > AMD and IA64? > > I call it "generic", because it can be used by EDAC, PCIe AER, Machine > Check, etc to report hardware errors, and it can work on AMD and > IA64. 1) that's not a complete answer -- I asked to the EDAC guys agree? Have you even tried talking to them? and 2) 'can' is not the right word here, I though we'd all agreed to talk about this and agree on some approach before littering the kernel with tiny special case interfaces.. which this will be if EDAC and others don't agree with you. So I want a firm agreement of all parties interested that this is the way forward, if not you already have my NAK. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/