Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754946Ab0KSPpu (ORCPT ); Fri, 19 Nov 2010 10:45:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:62496 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751150Ab0KSPps (ORCPT ); Fri, 19 Nov 2010 10:45:48 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1290120166-3132-4-git-send-email-zohar@linux.vnet.ibm.com> References: <1290120166-3132-4-git-send-email-zohar@linux.vnet.ibm.com> <1290120166-3132-1-git-send-email-zohar@linux.vnet.ibm.com> To: Mimi Zohar Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@linux-nfs.org, linux-crypto@vger.kernel.org, Jason Gunthorpe , James Morris , David Safford , Rajiv Andrade , Mimi Zohar Subject: Re: [PATCH v1.4 3/5] key: add tpm_send command Date: Fri, 19 Nov 2010 15:45:37 +0000 Message-ID: <9837.1290181537@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 442 Lines: 12 Mimi Zohar wrote: > +int tpm_send(u32 chip_num, void *cmd, int buflen) I'd recommend size_t for buflen; apart from that: Acked-by: David Howells -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/