Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755318Ab0KSP5T (ORCPT ); Fri, 19 Nov 2010 10:57:19 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:50512 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754896Ab0KSP5R (ORCPT ); Fri, 19 Nov 2010 10:57:17 -0500 MIME-Version: 1.0 In-Reply-To: <1290154233-28695-1-git-send-email-ying.huang@intel.com> References: <1290154233-28695-1-git-send-email-ying.huang@intel.com> From: Linus Torvalds Date: Fri, 19 Nov 2010 07:56:38 -0800 Message-ID: Subject: Re: [PATCH 0/2] Generic hardware error reporting support To: Huang Ying Cc: Len Brown , linux-kernel@vger.kernel.org, Andi Kleen , linux-acpi@vger.kernel.org, Peter Zijlstra , Andrew Morton , Ingo Molnar , Mauro Carvalho Chehab , Borislav Petkov , Thomas Gleixner Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1345 Lines: 32 On Fri, Nov 19, 2010 at 12:10 AM, Huang Ying wrote: > > This is used by APEI ERST and GEHS. But it is a generic hardware > error reporting mechanism and can be used by other hardware error > reporting mechanisms such as EDAC, PCIe AER, Machine Check, etc. Yeah, no. Really. We don't want some specific hardware error reporting mechanism. Hardware errors are way less common than other errors, so making something that is special to them just isn't very interesting. I seriously suggest that the only _sane_ way to handle hardware errors is to (a) admit that they are rare (b) not try to use some odd special mechanism for them (c) just 'printk' them so that you can use the absolutely most standard way to report them, and one that administrators are already used to and has support for network logging with existing tools etc. (d) and if you want to make them persistent and NMI-safe, just do that on the _printk_ level. That way, any NMI-safeness or persistency helps everybody. I really see _zero_ point to some hw-error-specific model. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/