Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755339Ab0KSP6G (ORCPT ); Fri, 19 Nov 2010 10:58:06 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:41530 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755183Ab0KSP6E convert rfc822-to-8bit (ORCPT ); Fri, 19 Nov 2010 10:58:04 -0500 MIME-Version: 1.0 In-Reply-To: <1290154233-28695-3-git-send-email-ying.huang@intel.com> References: <1290154233-28695-1-git-send-email-ying.huang@intel.com> <1290154233-28695-3-git-send-email-ying.huang@intel.com> From: Linus Torvalds Date: Fri, 19 Nov 2010 07:52:08 -0800 Message-ID: Subject: Re: [PATCH 2/2] Hardware error record persistent support To: Huang Ying Cc: Len Brown , linux-kernel@vger.kernel.org, Andi Kleen , linux-acpi@vger.kernel.org, Peter Zijlstra , Andrew Morton , Ingo Molnar , Mauro Carvalho Chehab , Borislav Petkov , Thomas Gleixner Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1427 Lines: 30 On Fri, Nov 19, 2010 at 12:10 AM, Huang Ying wrote: > Normally, corrected hardware error records will go through the kernel > processing and be logged to disk or network finally. ?But for > uncorrected errors, system may go panic directly for better error > containment, disk or network is not usable in this half-working > system. ?To avoid losing these valuable hardware error records, the > error records are saved into some kind of simple persistent storage > such as flash before panic, so that they can be read out after system > reboot successfully. I think this is totally the wrong thing to do. TOTALLY. The fact is, concentrating about "hardware errors" makes this something that I refuse to merge. It's such an idiotic approach that it's disgusting. Now, if this was designed to be a "hardware-backed persistent 'printk' buffer", and was explicitly meant to save not just some special hardware error, but catch all printk's (which may be due to hardware errors or oopses or warnings or whatever), that would be useful. But limiting it to just some special source of errors makes this pointless and not ever worth merging. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/